From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/audio: skip ELD query for force-off connectors
Date: Wed, 27 May 2026 14:32:39 +1000
Message-ID: <review-overall-20260526161925.17041-1-pmenzel@molgen.mpg.de>
In-Reply-To: <20260526161925.17041-1-pmenzel@molgen.mpg.de>
References: <20260526161925.17041-1-pmenzel@molgen.mpg.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Overall Series Review

Subject: drm/i915/audio: skip ELD query for force-off connectors
Author: Paul Menzel <pmenzel@molgen.mpg.de>
Patches: 1
Reviewed: 2026-05-27T14:32:39.446168

---

This is a single patch that addresses a real annoyance: when a connector is forced off via `video=<connector>:d`, the HDA audio driver repeatedly calls `get_eld()` for that port, getting `-EINVAL` each time, which produces noisy debug logs. The fix adds a helper that checks if any connector on the port is forced off, and returns a clean "not connected" (`*enabled = false`, return 0) instead of an error.

The approach is reasonable and the commit message is well-written with clear before/after log evidence. However, there is a **locking concern** and a **semantic question** worth discussing.

---
Generated by Claude Code Patch Reviewer