From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: add AIE coredump support Date: Wed, 27 May 2026 14:28:07 +1000 Message-ID: In-Reply-To: <20260526172943.1776017-1-lizhi.hou@amd.com> References: <20260526172943.1776017-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: add AIE coredump support Author: Lizhi Hou Patches: 1 Reviewed: 2026-05-27T14:28:07.674734 --- This is a single patch adding AIE coredump support to the `accel/amdxdna` driver, allowing per-context tile memory snapshots for post-mortem hardware debugging. The patch mixes two distinct changes: (1) refactoring the `amdxdna_alloc_msg_buffer`/`amdxdna_free_msg_buffer` API to use an opaque handle (`amdxdna_msg_buf_hdl`), and (2) adding the coredump ioctl and firmware message plumbing. These should arguably be separate patches for easier review and bisection. The overall design is reasonable: the coredump walks all clients and hardware contexts under `dev_lock` + SRCU protection, sends a firmware message, and copies results to userspace. The permission model (own-context or `CAP_SYS_ADMIN`) is appropriate. There are several concerns, ranging from a potential bug in the zero-buffers edge case to UAPI documentation issues, detailed below. --- --- Generated by Claude Code Patch Reviewer