From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vc4: fix krealloc() memory leak Date: Wed, 27 May 2026 14:21:18 +1000 Message-ID: In-Reply-To: <20260526184105.18962-5-grandmaster@al2klimov.de> References: <20260526184105.18962-5-grandmaster@al2klimov.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/vc4: fix krealloc() memory leak Author: "Alexander A. Klimov" Patches: 1 Reviewed: 2026-05-27T14:21:18.853622 --- This is a single patch fixing a genuine krealloc() memory leak bug in the VC4 shader validation code. The bug pattern is well-known: when `krealloc()` fails and returns NULL, writing that NULL back to the original pointer loses the reference to the still-allocated old memory. The fix is correct and minimal. The patch is part of a larger series (indicated by the `In-Reply-To` header referencing a `*-1-*` message), presumably fixing this same krealloc pattern across multiple drivers. **Verdict: The patch is correct and should be applied.** --- Generated by Claude Code Patch Reviewer