From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/probe-helper: honour connector->force in drm_helper_probe_detect() Date: Wed, 27 May 2026 14:18:39 +1000 Message-ID: In-Reply-To: <20260526191812.30542-2-pmenzel@molgen.mpg.de> References: <20260526191812.30542-2-pmenzel@molgen.mpg.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/probe-helper: honour connector->force in drm_helper_probe_dete= ct() Author: Paul Menzel Patches: 1 Reviewed: 2026-05-27T14:18:39.983377 --- This is a single patch (v2) that adds a short-circuit to `drm_helper_probe_= detect()` for connectors forced off via the `video=3D` kernel command-line = parameter. The motivation is sound =E2=80=94 there's a real asymmetry where= `drm_helper_probe_single_connector_modes()` (line 589) already skips detec= tion for forced connectors, but `drm_helper_probe_detect()` does not, causi= ng unnecessary hardware probes (AUX DPCD reads, etc.) for connectors the us= er explicitly disabled. The patch has one significant correctness bug: the condition `if (connector= ->force)` is true for **all** non-`DRM_FORCE_UNSPECIFIED` values including = `DRM_FORCE_ON` and `DRM_FORCE_ON_DIGITAL`, despite the commit message expli= citly claiming those are "intentionally not short-circuited." This directly= contradicts the v2 changelog note addressing Jani's feedback. --- Generated by Claude Code Patch Reviewer