From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Avoid using zero AC/DC brightness levels Date: Thu, 28 May 2026 12:44:12 +1000 Message-ID: In-Reply-To: <20260526210048.1162477-1-edson.drosdeck@gmail.com> References: <20260526210048.1162477-1-edson.drosdeck@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Avoid using zero AC/DC brightness levels Author: Edson Juliano Drosdeck Patches: 1 Reviewed: 2026-05-28T12:44:12.591232 --- This is a single-patch fix for a real-world issue where some systems report= zero `ac_level`/`dc_level` values from ACPI firmware during backlight init= ialization. When these are zero, `DIV_ROUND_CLOSEST((max - min) * 0, 100)` = yields zero brightness, which would set the panel to minimum brightness on = boot =E2=80=94 a bad user experience. The fix is straightforward and correct: add guards to reject zero values an= d fall through to the `MAX_BACKLIGHT_LEVEL` fallback. The code change is mi= nimal and low-risk. **Minor concerns exist** around the commit message and a potential edge cas= e with `max_brightness` not being set when the fallback fires, but overall = this is a reasonable fix. --- Generated by Claude Code Patch Reviewer