From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting Date: Wed, 27 May 2026 14:00:17 +1000 Message-ID: In-Reply-To: <20260526214446.3638616-1-jonathan.cavitt@intel.com> References: <20260526214446.3638616-1-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/xe/pagefault: Add SRCID to pagefault reporting Author: Jonathan Cavitt Patches: 3 Reviewed: 2026-05-27T14:00:17.515622 --- This is a small 2-patch series adding the SRCID (source ID of the faulting hardware unit) to the xe pagefault reporting path. The data flows from the GuC pagefault handler through the internal pagefault struct, gets saved into per-VM fault entries, and is exposed to userspace via the `xe_vm_get_property_ioctl`. The series is mostly clean, but **Patch 2 has a bug**: it accidentally removes the MBZ validation of the `pad` field in `drm_xe_vm_get_property`, which is completely unrelated to the srcid feature. Additionally, the UAPI for `srcid` lacks the `#define` documentation that the sibling fields have, making it harder for userspace to interpret the value. --- --- Generated by Claude Code Patch Reviewer