From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/probe-helper: Honour connector->force in drm_helper_probe_detect() Date: Wed, 27 May 2026 13:57:30 +1000 Message-ID: In-Reply-To: <20260526223203.42982-2-pmenzel@molgen.mpg.de> References: <20260526223203.42982-2-pmenzel@molgen.mpg.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/probe-helper: Honour connector->force in drm_helper_probe_dete= ct() Author: Paul Menzel Patches: 1 Reviewed: 2026-05-27T13:57:30.178462 --- This is a single well-motivated patch that fixes a real behavioral gap in t= he DRM probe helper infrastructure. The problem is clear: `drm_helper_probe= _single_connector_modes()` (line 595) already respects `connector->force` a= nd skips hardware detection when a connector is forced, but `drm_helper_pro= be_detect()` does not. Callers that go through `drm_helper_probe_detect()` = directly =E2=80=94 most notably i915's `intel_hotplug_detect_connector()` = =E2=80=94 perform unnecessary hardware probes (AUX/DPCD reads, DDC transact= ions) on connectors the user has explicitly forced off via `video=3D`. The fix is minimal, correct in scope, and well-placed. The decision to only= short-circuit `DRM_FORCE_OFF` (and not `DRM_FORCE_ON` / `DRM_FORCE_ON_DIGI= TAL`) is well-reasoned and explicitly documented in the commit message. **Recommendation: Looks good to merge.** --- Generated by Claude Code Patch Reviewer