From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: nova: enable calling into nova-core Date: Thu, 28 May 2026 12:21:59 +1000 Message-ID: In-Reply-To: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: drm: nova: enable calling into nova-core Author: Alexandre Courbot Patches: 11 Reviewed: 2026-05-28T12:21:59.491666 --- This is a well-structured 7-patch series enabling `nova-drm` to call into `= nova-core` as an interim workaround until the Rust build system natively su= pports cross-crate module dependencies. The approach is pragmatic: export R= ust symbols via generated C `EXPORT_SYMBOL_GPL()` calls, generate `.rmeta` = metadata for compile-time type resolution, and wire up the Makefile depende= ncies. The first three patches are preparatory fixes (modpost truncation de= tection, inlining to shrink symbol names) and the final patch is an explici= tly-labeled POC not intended for merge. **Key concerns:** 1. The modpost fix (patch 1) has a correctness issue with printing `tmp` af= ter truncation =E2=80=94 the content is already truncated/partial and may c= onfuse developers. 2. The `#[inline(always)]` patches are reasonable workarounds but scatter h= ints across core Rust infrastructure to fix a Nova-specific symbol length p= roblem =E2=80=94 this should be discussed with the Rust-for-Linux maintaine= rs since it affects all kernel Rust users. 3. The POC patch (7/7) has significant issues with self-referential struct = field ordering and `SAFETY` comments that don't fully address the concerns. Overall, patches 1-6 are in reasonable shape for a stated workaround. Patch= 7 needs rework if it were ever to be merged, but it's explicitly labeled a= s a POC. --- Generated by Claude Code Patch Reviewer