From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add SCDC information to connector debugfs Date: Thu, 28 May 2026 12:16:28 +1000 Message-ID: In-Reply-To: <20260527-scdc-link-health-v4-0-622ea40a1f59@collabora.com> References: <20260527-scdc-link-health-v4-0-622ea40a1f59@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add SCDC information to connector debugfs Author: Nicolas Frattaroli Patches: 5 Reviewed: 2026-05-28T12:16:28.428232 --- This is a well-structured 4-patch series that exposes HDMI SCDC (Status and Control Data Channel) link health information through DRM connector debugfs. The series progresses logically: fix return types (patch 1), add HDMI 2.0 SCDC debugfs (patch 2), wire it into bridge connectors (patch 3), then extend for HDMI 2.1 fields (patch 4). The code quality is good -- v4 changes show responsiveness to review feedback (dropping bitfield parsing, `__pure`, `!!` operators). The error counter checksum logic correctly handles the register layout gap between lane 2 and lane 3 (skipping the checksum register at 0x56). The connector ref-counting pattern in `scdc_status_show` is correct. I have one moderate concern (training pattern values are read but never displayed in debugfs), a few minor nits, and otherwise this looks ready. --- Generated by Claude Code Patch Reviewer