From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: i915: selftests: fix oa_config refcount leak in test_stream() Date: Thu, 28 May 2026 12:42:28 +1000 Message-ID: In-Reply-To: <20260527040835.854065-1-vulab@iscas.ac.cn> References: <20260527040835.854065-1-vulab@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: i915: selftests: fix oa_config refcount leak in test_stream() Author: Wentao Liang Patches: 1 Reviewed: 2026-05-28T12:42:28.615639 --- **NAK.** This single-patch series attempts to fix a refcount leak on the `!props.engine` error path in `test_stream()`, but the fix **introduces a NULL pointer dereference** that is strictly worse than the original leak. The patch moves the `!props.engine` check to *after* the line `gt = props.engine->gt;`, meaning if `props.engine` is NULL, the kernel will crash with a NULL dereference before it ever reaches the new guard. The identified bug (leaking the `oa_config` reference when `props.engine` is NULL) is real, but the fix is incorrect. --- Generated by Claude Code Patch Reviewer