From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: xe: selftests: fix fence refcount leak in run_sanity_job() Date: Thu, 28 May 2026 12:37:36 +1000 Message-ID: In-Reply-To: <20260527070244.858512-1-vulab@iscas.ac.cn> References: <20260527070244.858512-1-vulab@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: xe: selftests: fix fence refcount leak in run_sanity_job() Author: Wentao Liang Patches: 1 Reviewed: 2026-05-28T12:37:36.567576 --- This is a single-patch series claiming to fix a `dma_fence` refcount leak in `run_sanity_job()` in the xe driver's KUnit selftests. **The fix is correct and valid.** The function takes a reference via `dma_fence_get()` at line 55, then on the error path where `sanity_fence_failed()` returns true, the original code returned `-ETIMEDOUT` without calling `dma_fence_put()`, leaking the reference. The patch adds `dma_fence_put(fence)` before the early return, matching the `dma_fence_put(fence)` that already exists on the success path at line 63. However, there are issues with the commit metadata. --- Generated by Claude Code Patch Reviewer