From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS output Date: Thu, 28 May 2026 12:36:18 +1000 Message-ID: In-Reply-To: <20260527085736.920390-1-tessolveupstream@gmail.com> References: <20260527085736.920390-1-tessolveupstream@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: bridge: ti-sn65dsi83: Fix DSI mode flags for stable LVDS outp= ut Author: Sudarshan Shetty Patches: 3 Reviewed: 2026-05-28T12:36:18.878762 --- This is a straightforward 2-patch series that removes three DSI mode flags = (`MIPI_DSI_MODE_VIDEO_NO_HFP`, `MIPI_DSI_MODE_VIDEO_NO_HBP`, and `MIPI_DSI_= MODE_VIDEO_BURST`) from the ti-sn65dsi83 bridge driver to improve LVDS outp= ut stability. The changes are well-motivated. The driver explicitly programs HFP, HBP, hs= ync, and vsync timing values into the bridge chip's registers (lines 666=E2= =80=93679), meaning it depends on receiving these values from the DSI host.= Using `NO_HFP`/`NO_HBP` flags instructs the DSI host to suppress transmiss= ion of those blanking periods, which is contradictory =E2=80=94 the bridge = needs that timing information to reconstruct valid LVDS output. The removal= makes the driver's DSI-side configuration consistent with the register pro= gramming on the LVDS side. The split into two patches (HFP/HBP flags vs. burst mode) is appropriate si= nce the two changes have different justifications and different risk profil= es. The series has Tested-by tags from two independent testers (Luca Cereso= li and Alexander Stein), providing good validation. **Concern:** These are behavioral changes that affect all users of this dri= ver, not just the submitter's platform. Removing burst mode (patch 2) could= be a regression for platforms that currently work with burst mode. The com= mit message for patch 2 is honest about this ("depending on the host contro= ller implementation") but doesn't explain why non-burst mode is universally= correct. This is worth scrutiny from the maintainers. Overall: Patch 1 is clearly correct. Patch 2 is reasonable but more debatab= le. --- Generated by Claude Code Patch Reviewer