Claude review: clk: Add __clk_disable_unprepare_counts_only() and use this in simple[fb|drm]

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: clk: Add __clk_disable_unprepare_counts_only() and use this in simple[fb|drm]
Author: Hans de Goede <johannes.goede@oss.qualcomm.com>
Patches: 9
Reviewed: 2026-05-28T12:34:29.409298

---

This is a well-motivated series fixing a real problem: simpledrm/simplefb call `clk_disable_unprepare()` on teardown, which actually turns off clocks before the real display driver has loaded, leaving hardware in an undefined state on Qualcomm platforms. The proposed solution — decrement refcounts without touching hardware — is conceptually sound, and the cover letter is thorough in discussing alternatives.

However, the implementation has a significant gap: the counts-only unprepare path still calls `clk_pm_runtime_put()`, which can actually power down the clock controller device, undermining the "don't touch hardware" intent. The tracepoint emissions in the counts-only path are also misleading. These issues should be addressed before the clk maintainers are likely to accept this.

The simpledrm error-path change in patch 2 is also questionable — during init failure, the clocks were genuinely enabled by simpledrm itself and may actually need proper disable/unprepare.

---
Generated by Claude Code Patch Reviewer