From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vfio/pci: Add mmap() for DMABUFs Date: Thu, 28 May 2026 12:28:51 +1000 Message-ID: In-Reply-To: <20260527102319.100128-1-mattev@meta.com> References: <20260527102319.100128-1-mattev@meta.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: vfio/pci: Add mmap() for DMABUFs Author: Matt Evans Patches: 15 Reviewed: 2026-05-28T12:28:51.795261 --- This is a well-structured v2 series from Matt Evans (Meta) that converts VFIO PCI BAR mmap() to be backed by DMABUFs, then adds mmap() support for explicitly-exported DMABUFs, plus ioctl-based permanent revocation and memory attribute control. The goal is to allow userspace drivers to safely delegate BAR sub-ranges to subordinate processes via DMABUF fds. **Architecture**: The approach of unifying the BAR mmap path and explicit DMABUF mmap path under common fault-handling code is sound and follows prior review feedback. The lifecycle management -- with the BAR mmap DMABUF taking ownership of the device fd -- is a clever way to preserve existing behavior. **Concerns**: 1. The `#ifdef CONFIG_PCI_P2PDMA` / `#ifdef CONFIG_VFIO_PCI_DMABUF` guards sprinkled through `vfio_pci_dmabuf.c` (patch 4) create a file that compiles in multiple configurations with interleaved `#ifdef` blocks, which is fragile. 2. Patch 7's fault handler synchronization protocol (resv lock -> try_get_registration -> unlock resv -> memory_lock) is complex with 5 numbered steps. While thoroughly commented, this is a subtle ordering that future maintainers need to preserve. 3. The `bar_needs_zap` flag (patch 6) for nvgrace-gpu is a reasonable interim hack but deserves an actual timeline for removal. 4. Patch 9's use of `-ENOTSUPP` (kernel-internal) instead of `-EOPNOTSUPP` (POSIX) in a UAPI-facing path is a bug. Overall the series is in good shape for a v2. The code is well-commented, the cover letter is thorough, and the incremental approach is easy to follow. --- --- Generated by Claude Code Patch Reviewer