From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: Move dma_resv_assert_held() after input validation Date: Thu, 28 May 2026 12:25:30 +1000 Message-ID: In-Reply-To: <20260527104449.2350-1-lirongqing@baidu.com> References: <20260527104449.2350-1-lirongqing@baidu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: dma-buf: Move dma_resv_assert_held() after input validation Author: lirongqing Patches: 1 Reviewed: 2026-05-28T12:25:30.997300 --- This is a single patch that reorders a `dma_resv_assert_held()` call to com= e after NULL-pointer validation of `attach` and `attach->dmabuf` in `dma_bu= f_phys_vec_to_sgt()`. **The patch is technically correct in what it does** =E2=80=94 it does move= the `dma_resv_assert_held()` after the WARN_ON check =E2=80=94 but it addr= esses a problem that effectively cannot happen in practice. **Verdict: Low-value patch, borderline NAK-worthy.** --- Generated by Claude Code Patch Reviewer