From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Date: Thu, 28 May 2026 12:19:14 +1000 Message-ID: In-Reply-To: <20260527133917.207150-1-tzimmermann@suse.de> References: <20260527133917.207150-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Author: Thomas Zimmermann Patches: 11 Reviewed: 2026-05-28T12:19:14.368165 --- This is a well-structured 9-patch series from Thomas Zimmermann that addresses a real semantic problem: `DRM_IOCTL_WAIT_VBLANK` (and the newer `CRTC_GET_SEQUENCE`/`CRTC_QUEUE_SEQUENCE` ioctls) being available on devices that only have software-simulated vblank timers (no hardware vblank interrupt). For such devices, waiting for vblank is meaningless since the timer is not synchronized to any display refresh. The approach is clean: patch 1 renames the init function to `drmm_vblank_init()` with a flags parameter, patch 2 adds the `DRM_VBLANK_FLAG_SIMULATED` flag and the ioctl filtering, and patches 3-9 convert the known simulated-vblank drivers. The series is logically ordered and easy to bisect. **Overall: looks good.** A few minor observations below, none blocking. --- Generated by Claude Code Patch Reviewer