From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Internalize fbcon Date: Thu, 28 May 2026 12:12:50 +1000 Message-ID: In-Reply-To: <20260527151551.258659-1-tzimmermann@suse.de> References: <20260527151551.258659-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbdev: Internalize fbcon Author: Thomas Zimmermann Patches: 5 Reviewed: 2026-05-28T12:12:50.722397 --- This is a well-structured 4-patch series that incrementalizes fbcon into an internal implementation detail of fbdev. The approach is sound: wrap the user-facing operations (`fb_set_var`, `fb_blank`, vga-switcheroo remap) in helpers that encapsulate the fbcon interaction, then move the declarations into a private header. The series is cleanly split and easy to follow. There is one **behavioral regression** in patch 1 affecting `sh_mobile_lcdcfb` that should be addressed before merging. --- --- Generated by Claude Code Patch Reviewer