From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: Fix clippy error in Vbios::new() Date: Thu, 28 May 2026 12:09:53 +1000 Message-ID: In-Reply-To: <20260527171521.2406456-1-lyude@redhat.com> References: <20260527171521.2406456-1-lyude@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: vbios: Fix clippy error in Vbios::new() Author: Lyude Paul Patches: 2 Reviewed: 2026-05-28T12:09:53.398378 --- This is a single-patch series from Lyude Paul fixing a clippy lint (`collap= sible_match`) in the nova-core VBIOS parser. The fix moves a guard conditio= n from an `if` inside a match arm body into a match guard on the arm itself= . The change is straightforward and correct =E2=80=94 the behavior is prese= rved because a failed match guard in Rust falls through to subsequent arms,= and the catch-all `_ =3D>` arm is a no-op that simply ignores unrecognized= image types. **Verdict: Looks good.** Minor nit on comment placement below. --- Generated by Claude Code Patch Reviewer