From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ttm/pool: Don't leak LRU list on shutdown Date: Thu, 28 May 2026 12:06:59 +1000 Message-ID: In-Reply-To: <20260527202018.1223912-1-ian.forbes@broadcom.com> References: <20260527202018.1223912-1-ian.forbes@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: ttm/pool: Don't leak LRU list on shutdown Author: Ian Forbes Patches: 1 Reviewed: 2026-05-28T12:06:59.833344 --- This is a single-patch fix for a memory leak in the TTM pool subsystem. The analysis is straightforward and correct: commit `444e2a19d7fd` changed `pt->pages` from a plain `list_head` to a `list_lru`, which requires `list_lru_init()` at creation and `list_lru_destroy()` at teardown. The init call was added (line 357) but the corresponding destroy was missed in `ttm_pool_type_fini()`. This would leak per-node `list_lru_node` allocations every time a pool type is torn down, as confirmed by the author via kmemleak + `igt@core_hotunplug`. The fix is minimal, correctly placed, and the series is ready to merge. --- Generated by Claude Code Patch Reviewer