From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exec: drm_exec.h: eliminate kernel-doc warnings Date: Thu, 28 May 2026 12:04:23 +1000 Message-ID: In-Reply-To: <20260527220018.1231829-1-rdunlap@infradead.org> References: <20260527220018.1231829-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/exec: drm_exec.h: eliminate kernel-doc warnings Author: Randy Dunlap Patches: 1 Reviewed: 2026-05-28T12:04:23.470549 --- This is a single-patch series from Randy Dunlap fixing kernel-doc warnings = in `include/drm/drm_exec.h`. The patch is trivial and correct =E2=80=94 it = addresses two distinct kernel-doc issues: 1. **Missing `Returns:` tag** =E2=80=94 kernel-doc requires `Returns:` (wit= h colon) rather than just `Returns` for return value documentation. 2. **Parameter name mismatch** =E2=80=94 the `drm_exec_retry()` macro uses = `_exec` as its parameter name but the kernel-doc documented it as `@exec`. Both fixes are mechanical and match the actual code. The Fixes tag referenc= es `bba175a2d4be ("drm/exec, drm/xe: Avoid abusing the drm_exec retry point= er")` which introduced `drm_exec_retry()` with the underscore-prefixed para= meter and the `drm_exec_is_contended()` return value issue. Note: The patch= es did not apply to the drm-next tree because the referenced commit (which = adds `drm_exec_retry()`) has not yet landed on drm-next =E2=80=94 the tree = only has `drm_exec_retry_on_contention`, not `drm_exec_retry`. **Verdict: Patch looks good.** No functional concerns. --- Generated by Claude Code Patch Reviewer