From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Add BeagleY-AI display support (and some more) Date: Thu, 04 Jun 2026 16:54:10 +1000 Message-ID: In-Reply-To: <20260529-beagley-ai-display-v3-0-7fefdc5d1adf@ideasonboard.com> References: <20260529-beagley-ai-display-v3-0-7fefdc5d1adf@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/tidss: Add BeagleY-AI display support (and some more) Author: Tomi Valkeinen Patches: 18 Reviewed: 2026-06-04T16:54:10.205422 --- This is a well-structured 15-patch series from Tomi Valkeinen (with contributions from others at TI) adding display support for TI AM62P/J722S/AM67A SoCs, most notably enabling HDMI output on the BeagleY-AI board. The series covers: 1. **DT bindings** (patches 1-5): Cleanly separates AM62L into its own binding file, simplifies the AM65x binding, adds OLDI power-domain and DPI io-ctrl properties, and adds AM62P DSS. 2. **Driver cleanups** (patches 6-7): Minor housekeeping. 3. **DPI detection & configuration** (patches 8-10): Adds infrastructure to detect whether output is DPI, configure external signal edge polarity via syscon, and manage the DPIENABLE bit. 4. **OLDI improvements** (patches 11-12): Fixes signal polarity handling, and converts OLDI to an auxiliary device/driver for proper power-domain management. 5. **AM62P support & board DTS** (patches 13-15): Adds the AM62P compatible, the SoC-level DTS nodes, and enables HDMI on BeagleY-AI. The series is generally well-done with good commit messages and a sensible patch ordering. The OLDI aux driver conversion (patch 12) is the most complex and architecturally significant change. The DT bindings have Rob Herring's Reviewed-by. Most patches carry Tested-by tags. I have a few concerns worth examining, detailed below. --- Generated by Claude Code Patch Reviewer