From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding Date: Thu, 04 Jun 2026 16:57:32 +1000 Message-ID: In-Reply-To: <20260529-nova-unload-v7-0-678f39209e00@nvidia.com> References: <20260529-nova-unload-v7-0-678f39209e00@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: run unload sequence upon unbinding Author: Alexandre Courbot Patches: 9 Reviewed: 2026-06-04T16:57:32.956770 --- This is a well-structured 4-patch series by Alexandre Courbot (NVIDIA) that= adds proper GPU unload/teardown for the nova-core driver. Currently, when = the driver unbinds, the GSP firmware is left running and the WPR2 memory re= gion is not cleaned up, which means a GPU reset is required before the driv= er can probe again. This is particularly problematic on Blackwell where PCI= reset can corrupt the GPU. The series is logically decomposed: 1. Extract chipset-specific boot code into a HAL pattern 2. Send the `UNLOADING_GUEST_DRIVER` command to stop the GSP 3. Run Booter Unloader and FWSEC-SB to reset WPR2 region 4. Add a drop guard to run the unload bundle on boot failure The code quality is high =E2=80=94 good error handling, proper use of Rust'= s type system to enforce lifecycle constraints (one-shot unload bundle, dro= p guards), and the HAL abstraction prepares cleanly for Hopper/Blackwell FS= P boot paths. The v7 changelog shows this series has received thorough revi= ew iterations. **Verdict**: Looks good overall. A few observations below, mostly minor. --- --- Generated by Claude Code Patch Reviewer