From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: Add SY7758 6-channel High Efficiency LED Driver support Date: Thu, 04 Jun 2026 16:03:08 +1000 Message-ID: In-Reply-To: <20260529-topic-sm8650-ayaneo-pocket-s2-sy7758-v5-0-03aacd49747c@linaro.org> References: <20260529-topic-sm8650-ayaneo-pocket-s2-sy7758-v5-0-03aacd49747c@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: backlight: Add SY7758 6-channel High Efficiency LED Driver support Author: Neil Armstrong Patches: 3 Reviewed: 2026-06-04T16:03:08.474195 --- This is a clean, well-structured 2-patch series adding support for the Sile= rgy SY7758 6-channel LED backlight driver, used in the Ayaneo Pocket S2 han= dheld. The DT binding is minimal and follows existing patterns. The driver = is compact and follows the established backlight driver idioms (ktz8866, aw= 99706). This is v5 with several rounds of review already incorporated. There are a few concerns worth discussing: 1. **All hardware configuration is hardcoded** in `sy7758_init()`, making t= he driver specific to the Ayaneo Pocket S2 board rather than a generic SY77= 58 driver. A different board using this chip would need different current, = PWM, and boost settings, but there's no DT property to configure them. 2. **Brightness=3D0 doesn't disable the LED channels** =E2=80=94 the driver= only writes zero to the brightness registers but never clears `BIT_CFG2_BL= _ON`, so the chip stays powered even at minimum brightness. 3. Minor style nits (redundant masking, unused initialization). None of these are blockers for a first version targeting a specific board, = but items 1 and 2 are worth discussing. --- --- Generated by Claude Code Patch Reviewer