From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/omap: dsi: avoid sending bta sync all the time in writes Date: Thu, 04 Jun 2026 16:00:55 +1000 Message-ID: In-Reply-To: <20260529-vm-upstr-v2-1-24c30671719f@kernel.org> References: <20260529-vm-upstr-v2-1-24c30671719f@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/omap: dsi: avoid sending bta sync all the time in writes Author: akemnade@kernel.org Patches: 1 Reviewed: 2026-06-04T16:00:55.211314 --- This is a single-patch fix for the OMAP DSI driver, addressing a real hardware issue with bridge chips (TC358762) that cannot respond to BTA sync requests before they are fully configured. The approach is sound: stop unconditionally sending BTA sync on every write, and instead wait for the PACKET_SENT IRQ for long packets (to avoid FIFO overflows) and skip waiting entirely for short packets. The command-mode update path is fixed to use a bare BTA sync instead of a NOP (which would no longer trigger BTA sync after this change). The patch is well-motivated, has been tested on both video mode (OMAP4 BT-200) and command mode (droid4), and carries a Tested-by. The overall design is correct, though there are a few issues worth noting. **Verdict:** Mostly good. A couple of minor issues, one potential race concern. --- Generated by Claude Code Patch Reviewer