From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Add bounds checks for firmware log indices Date: Thu, 04 Jun 2026 16:39:02 +1000 Message-ID: In-Reply-To: <20260529115842.135378-1-andrzej.kacprowski@linux.intel.com> References: <20260529115842.135378-1-andrzej.kacprowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Add bounds checks for firmware log indices Author: Andrzej Kacprowski Patches: 3 Reviewed: 2026-06-04T16:39:02.376357 --- This is a single-patch series that adds bounds checking to firmware log ind= ices (`read_index` and `write_index`) in the IVPU (Intel VPU accelerator) d= river. The firmware writes these indices and the host reads them via `READ_= ONCE()`, so they are an untrusted input boundary that should be validated. = The fix is targeted at a real bug class =E2=80=94 out-of-bounds buffer acce= ss from malicious or corrupted firmware data =E2=80=94 and is appropriately= tagged for stable backport. The patch is **mostly correct** but has an **asymmetry in the boundary chec= ks** that appears to be a bug, and there are some additional considerations= worth discussing. --- Generated by Claude Code Patch Reviewer