From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/edp: Check supported link rates DPCD read Date: Thu, 04 Jun 2026 16:37:23 +1000 Message-ID: In-Reply-To: <20260529120921.1633346-1-n.zhandarovich@fintech.ru> References: <20260529120921.1633346-1-n.zhandarovich@fintech.ru> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915/edp: Check supported link rates DPCD read Author: Nikita Zhandarovich Patches: 2 Reviewed: 2026-06-04T16:37:23.909532 --- This is a single-patch series that adds error checking to the `drm_dp_dpcd_= read()` call in `intel_edp_set_sink_rates()`. The motivation is reasonable = =E2=80=94 the existing code reads DPCD supported link rates into a stack-al= located array and parses it unconditionally, which could use uninitialized = stack data if the read fails or is short. The fix approach is sensible: che= ck the return value and fall back to default rate handling on failure. However, the patch has a notable mismatch with the current upstream code an= d some minor issues worth addressing. **Verdict**: Reasonable defensive fix with minor issues. Needs a small upda= te to match the current kernel tree. --- Generated by Claude Code Patch Reviewer