From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: Fix OOB read in MC register table init
Date: Thu, 04 Jun 2026 16:32:17 +1000 [thread overview]
Message-ID: <review-overall-20260529121436.1633842-1-n.zhandarovich@fintech.ru> (raw)
In-Reply-To: <20260529121436.1633842-1-n.zhandarovich@fintech.ru>
Overall Series Review
Subject: drm/radeon: Fix OOB read in MC register table init
Author: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Patches: 1
Reviewed: 2026-06-04T16:32:17.369199
---
This is a single, straightforward defensive fix for a potential out-of-bounds read in the radeon driver's ATOMBIOS MC register table initialization. The patch is correct, minimal, and mirrors an identical fix already applied to the amdgpu counterpart (commit 51dfc0a4d609). The bug is real: when `i == 0` and `DATA_EQU_PREV` is set, `mc_data[i - 1]` reads `mc_data[-1]`, which is an OOB access into the preceding struct member or adjacent memory.
**Verdict: Looks good.** No concerns with correctness.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 12:14 [PATCH] drm/radeon: Fix OOB read in MC register table init Nikita Zhandarovich
2026-06-04 6:32 ` Claude Code Review Bot [this message]
2026-06-04 6:32 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260529121436.1633842-1-n.zhandarovich@fintech.ru \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox