From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Return errors for failed debug BO commands Date: Thu, 04 Jun 2026 16:14:42 +1000 Message-ID: In-Reply-To: <20260529162122.1976376-1-lizhi.hou@amd.com> References: <20260529162122.1976376-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Return errors for failed debug BO commands Author: Lizhi Hou Patches: 2 Reviewed: 2026-06-04T16:14:42.300725 --- This is a single-patch bugfix for the `accel/amdxdna` driver. The patch fixes two related problems where debug BO (buffer object) config/sync commands could silently report success to userspace despite firmware failures: 1. The response handler `aie2_sched_drvcmd_resp_handler` returned success (ret=0) and left `result` at its zero-initialized value when `data` was NULL, making callers believe the command succeeded. 2. `aie2_hwctx_cfg_debug_bo` never set `ret` to an error code when `cmd.result` indicated a firmware failure, so it returned 0 to userspace despite logging an error. The fix is small, correct, and well-targeted. One minor observation below about the commit message scope. --- Generated by Claude Code Patch Reviewer