From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Convert all reset users to create_state Date: Thu, 04 Jun 2026 15:45:41 +1000 Message-ID: In-Reply-To: <20260530-drm-no-more-bridge-reset-v1-0-875d828d31bc@kernel.org> References: <20260530-drm-no-more-bridge-reset-v1-0-875d828d31bc@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: Convert all reset users to create_state Author: Maxime Ripard Patches: 107 Reviewed: 2026-06-04T15:45:41.495104 --- This is a 76-patch series from Maxime Ripard that replaces the `atomic_reset` bridge callback with a new `atomic_create_state` callback. The motivation is sound: `atomic_reset` has misleading naming since it never actually resets hardware -- it only allocates and initializes pristine state. The new `atomic_create_state` makes this contract explicit. The series follows a clean structure: - Patches 1-3: Preparatory refactoring of the `__drm_atomic_helper_bridge_reset` helper (rename, reorder args, drop redundant memset) - Patch 4: Add `atomic_create_state` callback to core - Patch 5: Add `drm_atomic_helper_bridge_create_state()` helper - Patches 6-71: Mechanical driver conversions (one per driver) - Patch 72: Remove `drm_atomic_helper_bridge_reset()` - Patches 73-75: Handle the two cdns drivers (special cases with subclassed state) - Patch 76: Remove `atomic_reset` from core **However, there is a critical bisectability problem.** Patch 4 *replaces* `atomic_reset` with `atomic_create_state` in `struct drm_bridge_funcs`, yet: 1. The fallback code in `drm_bridge.c` (also added in patch 4) still references `bridge->funcs->atomic_reset` 2. All unconverted drivers (patches 6-71) still set `.atomic_reset = ...` This means the tree will not compile from patch 4 until all drivers are converted, breaking git-bisect. --- --- Generated by Claude Code Patch Reviewer