From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: implement dmem.high soft limit via prioritized eviction
Date: Thu, 04 Jun 2026 15:52:23 +1000 [thread overview]
Message-ID: <review-overall-20260530-feature-dmem-high-v4-1-ee7c6ec1c8da@gmail.com> (raw)
In-Reply-To: <20260530-feature-dmem-high-v4-1-ee7c6ec1c8da@gmail.com>
Overall Series Review
Subject: cgroup/dmem: implement dmem.high soft limit via prioritized eviction
Author: Qiliang Yuan <realwujing@gmail.com>
Patches: 1
Reviewed: 2026-06-04T15:52:23.141901
---
This is a single-patch series (v4) adding a `dmem.high` soft limit to the dmem cgroup v2 controller. The concept is sound: when eviction is triggered (e.g., by a `max` limit hit), BOs from cgroups exceeding their `dmem.high` soft limit are evicted first, providing a prioritized reclaim mechanism rather than the rejected sleep-on-allocation approach from v1.
The cgroupfs plumbing (control file, get/set, initialization) follows existing patterns well. However, the TTM eviction changes have two significant bugs: Pass 2 runs with blocking lock instead of trylock (the `trylock_only` flag is never restored after Pass 1), and the `try_high` path in `dmem_cgroup_state_evict_valuable()` skips the hierarchy check between `limit_pool` and `test_pool`, meaning BOs from completely unrelated cgroups can be evicted if any of their ancestors happens to exceed its high limit.
**Verdict: Needs revision** — the trylock regression and the missing hierarchy check need to be fixed before this can be merged.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 7:35 [PATCH v4] cgroup/dmem: implement dmem.high soft limit via prioritized eviction Qiliang Yuan
2026-06-04 5:52 ` Claude Code Review Bot [this message]
2026-06-04 5:52 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-31 8:45 [PATCH v5] " Qiliang Yuan
2026-06-04 5:03 ` Claude review: " Claude Code Review Bot
2026-06-04 5:03 ` Claude Code Review Bot
2026-05-31 9:52 [PATCH v6] " Qiliang Yuan
2026-06-04 4:56 ` Claude review: " Claude Code Review Bot
2026-06-04 4:56 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260530-feature-dmem-high-v4-1-ee7c6ec1c8da@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox