From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: introduce PAGE_FLIP_EVENT property Date: Thu, 04 Jun 2026 15:29:59 +1000 Message-ID: In-Reply-To: <20260530171422.4615-1-contact@emersion.fr> References: <20260530171422.4615-1-contact@emersion.fr> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: introduce PAGE_FLIP_EVENT property Author: Simon Ser Patches: 3 Reviewed: 2026-06-04T15:29:59.502018 --- This is a single patch from Simon Ser that introduces a new `PAGE_FLIP_EVEN= T` atomic CRTC property, allowing userspace to request page-flip events on = a per-CRTC basis rather than the current all-or-nothing `DRM_MODE_PAGE_FLIP= _EVENT` flag. The motivation is well-explained and addresses real pain poin= ts in compositors (gamescope, libliftoff, wlroots). The approach is sound and follows established patterns (modeled after `OUT_= FENCE_PTR` =E2=80=94 always reads as zero, write-only semantic). The implem= entation is compact and mostly correct, but there is one significant bug ar= ound state duplication/reset and a few smaller issues worth discussing. **Key concern:** The new `page_flip_event_requested` field in `drm_crtc_sta= te` is not cleared in `__drm_atomic_helper_crtc_duplicate_state()`, which m= eans it could carry over from a previous committed state if the memcpy copi= es a stale `true` value. This is unlike `event`, `async_flip`, and other pe= r-commit fields that are explicitly cleared there. --- Generated by Claude Code Patch Reviewer