From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Improve logic behind damage handling Date: Thu, 04 Jun 2026 15:21:20 +1000 Message-ID: In-Reply-To: <20260530185716.65688-1-tzimmermann@suse.de> References: <20260530185716.65688-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: Improve logic behind damage handling Author: Thomas Zimmermann Patches: 22 Reviewed: 2026-06-04T15:21:20.564314 --- This is a well-structured 10-patch series from Thomas Zimmermann that cleans up and consolidates DRM damage clipping logic. The core insight is correct: damage evaluation was happening too early (before `atomic_check`), which meant driver `atomic_check` callbacks could trigger a modeset that invalidated the already-evaluated damage state. The series addresses this by: 1. Moving damage evaluation to **after** all `atomic_check` callbacks run 2. Using the `ignore_damage_clips` flag instead of destroying the damage blob 3. Moving src-coordinate comparison from the iterator into the check phase 4. Progressively removing the now-unnecessary `old_state` parameter from damage helpers The series is well-ordered in v4 to avoid error-prone intermediate states, has appropriate acks/reviews from Zack Rusin and others, and includes kunit test updates. The approach is sound and the code is clean. No correctness bugs found. --- Generated by Claude Code Patch Reviewer