From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: add EDID re-read retry in msm_dp_panel_get_modes() Date: Thu, 04 Jun 2026 14:42:15 +1000 Message-ID: In-Reply-To: <20260531-drm_plug_flaky_edid-v1-1-2708c16dce97@oldschoolsolutions.biz> References: <20260531-drm_plug_flaky_edid-v1-1-2708c16dce97@oldschoolsolutions.biz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dp: add EDID re-read retry in msm_dp_panel_get_modes() Author: Jens Glathe via B4 Relay Patches: 5 Reviewed: 2026-06-04T14:42:15.755995 --- This is a single patch that adds EDID re-read retry logic to `msm_dp_panel_= get_modes()` to handle the case where the initial EDID read (done in `msm_d= p_panel_read_sink_caps()` during HPD) returns a structurally valid but cont= ent-deficient EDID that yields zero modes. The problem being addressed is real =E2=80=94 flaky USB-C/DP adapters can p= roduce garbage EDIDs, and retrying the read is a reasonable workaround. How= ever, the implementation has several significant issues with correctness, p= lacement, and missing checks. **Verdict: Needs rework.** The retry logic belongs in `msm_dp_panel_read_si= nk_caps()` where the EDID is originally read, not in `get_modes()`. The cur= rent patch also has bugs around the zero-modes-from-re-read path and introd= uces sleeping in a callback context that may not be appropriate. --- --- Generated by Claude Code Patch Reviewer