From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: tu102: keep unloading if FWSEC-SB fails Date: Thu, 04 Jun 2026 14:51:00 +1000 Message-ID: In-Reply-To: <20260531-nova-unload-fix-v1-1-c8dcdc769b53@nvidia.com> References: <20260531-nova-unload-fix-v1-1-c8dcdc769b53@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: gsp: tu102: keep unloading if FWSEC-SB fails Author: Alexandre Courbot Patches: 4 Reviewed: 2026-06-04T14:51:00.441389 --- This is a single-patch fix for the nova-core GPU driver's GSP unload path o= n Turing/Ampere hardware. The fix is straightforward and correct: the origi= nal code used `?` on the FWSEC-SB call, meaning a failure there would skip = the Booter Unloader entirely. Since these two firmware operations are indep= endent, this is wrong =E2=80=94 we should attempt both regardless of indivi= dual failures. The patch is well-motivated, properly tagged with `Fixes:`, and the approac= h is sound. The use of `inspect_err` for logging plus `Result::and` for com= bining errors is idiomatic Rust. **Verdict: Patch looks good.** --- Generated by Claude Code Patch Reviewer