From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Fix perfmon locking and cross-queue isolation
Date: Thu, 04 Jun 2026 14:44:42 +1000 [thread overview]
Message-ID: <review-overall-20260531-v3d-perfmon-lifetime-v2-0-60ed4485a203@igalia.com> (raw)
In-Reply-To: <20260531-v3d-perfmon-lifetime-v2-0-60ed4485a203@igalia.com>
Overall Series Review
Subject: drm/v3d: Fix perfmon locking and cross-queue isolation
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 10
Reviewed: 2026-06-04T14:44:42.323803
---
This is a well-structured 4-patch series from Maíra Canal that addresses three real, long-standing correctness issues in v3d's performance monitor subsystem: (1) lock-free access to `active_perfmon`, (2) perfmons never being stopped after job completion, and (3) cross-queue counter pollution. The cover letter clearly describes the problems and the approach.
The series is logically decomposed: patch 1 is a self-contained stable fix for refcount leaks, patch 2 is the major locking refactor, patch 3 adds cross-queue serialization via fence dependencies, and patch 4 is a trivial cleanup. The dependency on a prerequisite series (the submission refactoring) introduces a `v3d_submit` abstraction used in patches 3-4 that isn't present in drm-next today, but the patches are internally consistent.
**Overall verdict**: Good series. A few points worth discussing, mainly around locking subtleties in patch 2 and a potential race window in patch 3, but nothing blocking.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 4:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 20:18 [PATCH v2 0/4] drm/v3d: Fix perfmon locking and cross-queue isolation Maíra Canal
2026-05-31 20:18 ` [PATCH v2 1/4] drm/v3d: Fix global performance monitor reference counting Maíra Canal
2026-06-04 4:44 ` Claude review: " Claude Code Review Bot
2026-05-31 20:18 ` [PATCH v2 2/4] drm/v3d: Refactor perfmon locking Maíra Canal
2026-06-01 11:52 ` Iago Toral
2026-06-01 12:03 ` Maíra Canal
2026-06-04 4:44 ` Claude review: " Claude Code Review Bot
2026-05-31 20:18 ` [PATCH v2 3/4] drm/v3d: Serialize jobs across queues when a perfmon is attached Maíra Canal
2026-06-02 7:35 ` Iago Toral
2026-06-02 10:49 ` Maíra Canal
2026-06-02 11:10 ` Iago Toral
2026-06-04 4:44 ` Claude review: " Claude Code Review Bot
2026-05-31 20:18 ` [PATCH v2 4/4] drm/v3d: Drop the queue argument from v3d_job_add_syncobjs() Maíra Canal
2026-06-04 4:44 ` Claude review: " Claude Code Review Bot
2026-06-04 4:44 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260531-v3d-perfmon-lifetime-v2-0-60ed4485a203@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox