From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dynamic-debug cleanups refactors maintenance + alignment fix Date: Thu, 04 Jun 2026 14:06:55 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dynamic-debug cleanups refactors maintenance + alignment fix Author: Jim Cromie Patches: 25 Reviewed: 2026-06-04T14:06:55.467449 --- This is a substantial 24-patch series from Jim Cromie for dynamic-debug (dyndbg) maintenance, cleanup, refactoring, and a bug fix. The series is well-structured in a logical progression: 1. **Patches 1-2**: Documentation updates 2. **Patches 3-7**: Linker script alignment fix (the actual bug fix for NULL ptr on i386) 3. **Patches 8-21**: Dyndbg internals cleanup and refactoring (code factoring, API simplification, struct reorganization, u64 upgrade) 4. **Patch 22**: Selftest addition 5. **Patches 23-24**: Expression macro fix for Xe driver, and KBUILD_MODFILE for unique builtin names The DRM-relevant portions are relatively small: patch 18 changes `__drm_debug` from `unsigned long` to `u64` and renames `struct ddebug_class_param` to `struct _ddebug_class_param` in drm_print.c, and patch 19 renames section names (__dyndbg -> __dyndbg_descs). These are reasonable changes tied to the broader refactoring. Most patches have Reviewed-by from Louis Chauvet, and the linker script patches have Reviewed-by from Petr Pavlu. **Concerns**: The cover letter still has the "EDITME" placeholders in the v3 changes section. The `for_subvec` macro (patch 17) and `dd_set_module_subrange` macro (patch 21) are somewhat unusual/complex macro patterns that may be harder to maintain. The KBUILD_MODFILE change (patch 24) is a user-visible change that alters `/proc/dynamic_debug/control` output format for builtins. Overall this is a well-organized cleanup series. The section alignment fix (patches 3-7) is the most important functional change. --- Generated by Claude Code Patch Reviewer