From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/lima: call drm_mm_init() with a valid allocation range
Date: Thu, 04 Jun 2026 14:10:22 +1000 [thread overview]
Message-ID: <review-overall-20260601-lima-alloc-fix-v1-1-16d3f3b7b780@axis.com> (raw)
In-Reply-To: <20260601-lima-alloc-fix-v1-1-16d3f3b7b780@axis.com>
Overall Series Review
Subject: drm/lima: call drm_mm_init() with a valid allocation range
Author: Henrik Grimler <henrik.grimler@axis.com>
Patches: 2
Reviewed: 2026-06-04T14:10:22.015325
---
This is a single-patch fix for a real bug in the lima driver where `lima_vm_create()` is called before `ldev->va_start` and `ldev->va_end` are initialized, resulting in `drm_mm_init()` being called with a zero-size range. With `DRM_DEBUG_MM` enabled, this triggers a `BUG_ON`. The diagnosis and fix direction are correct — moving `lima_vm_create()` after the VA range setup is the right thing to do.
However, **the patch introduces a resource leak on the error path for mali450 devices**. The error goto labels are not updated to match the new initialization order, so a `lima_vm_create()` failure on mali450 will leak the `dlbu_cpu` DMA allocation.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 4:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 12:03 [PATCH] drm/lima: call drm_mm_init() with a valid allocation range Henrik Grimler
2026-06-02 7:16 ` Qiang Yu
2026-06-04 4:10 ` Claude review: " Claude Code Review Bot
2026-06-04 4:10 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260601-lima-alloc-fix-v1-1-16d3f3b7b780@axis.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox