From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Fix indirect CSD jobs with zeroed workgroups Date: Thu, 04 Jun 2026 13:44:21 +1000 Message-ID: In-Reply-To: <20260601-v3d-fix-indirect-csd-v2-0-aaebf035b936@igalia.com> References: <20260601-v3d-fix-indirect-csd-v2-0-aaebf035b936@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Fix indirect CSD jobs with zeroed workgroups Author: =3D?utf-8?q?Ma=3DC3=3DADra_Canal?=3D Patches: 4 Reviewed: 2026-06-04T13:44:21.425217 --- This is a clean, well-targeted 2-patch bugfix series for the V3D DRM driver= 's indirect CSD (Compute Shader Dispatch) path. Indirect CSD allows userspa= ce to defer workgroup counts to a GPU buffer that is only resolved at runti= me. When those counts legitimately turn out to be zero, two bugs are expose= d: (1) a vaddr leak and (2) the hardware misinterpreting 0 as 65536 workgro= ups. The series is correctly ordered =E2=80=94 patch 1 fixes the resource leak i= n the CPU job rewrite function, and patch 2 prevents the invalid dispatch f= rom reaching hardware. Both are tagged for stable, which is appropriate giv= en these are correctness/resource-leak fixes with minimal risk. The v2 chan= ges (checking only the workgroup count fields via `V3D_GET_FIELD` rather th= an the entire cfg register, plus an explanatory comment) address reviewer f= eedback well. No significant issues found. The series looks good to merge. --- Generated by Claude Code Patch Reviewer