public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/virtio: abort virtqueue wait on device removal to avoid hung task
Date: Thu, 04 Jun 2026 14:31:07 +1000	[thread overview]
Message-ID: <review-overall-20260601-virtio-gpu_wait_event-v3-1-89530517a98a@redhat.com> (raw)
In-Reply-To: <20260601-virtio-gpu_wait_event-v3-1-89530517a98a@redhat.com>

Overall Series Review

Subject: drm/virtio: abort virtqueue wait on device removal to avoid hung task
Author: Ryosuke Yasuoka <ryasuoka@redhat.com>
Patches: 2
Reviewed: 2026-06-04T14:31:07.760561

---

This is a single-patch fix for a real hang scenario in the virtio-gpu driver. The problem is well-identified: `wait_event()` calls in `virtio_gpu_queue_ctrl_sgs()` and `virtio_gpu_queue_cursor()` can block indefinitely if the host stops processing commands, and since they're inside `drm_dev_enter()`/`drm_dev_exit()` critical sections, `drm_dev_unplug()` (which calls `synchronize_srcu()`) will also hang, blocking device removal and system shutdown.

The approach — adding a `vqs_released` flag checked in the wait condition, set before `drm_dev_unplug()` — is a reasonable and straightforward solution. The cleanup paths mirror the existing `drm_dev_enter()` failure paths, which is correct.

**Overall: The patch is a solid fix for a real problem. There are a few concerns worth raising, mostly around memory ordering and minor style, but nothing blocking.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  4:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  7:53 [PATCH v3] drm/virtio: abort virtqueue wait on device removal to avoid hung task Ryosuke Yasuoka
2026-06-03  1:23 ` Dmitry Osipenko
2026-06-04  4:31 ` Claude Code Review Bot [this message]
2026-06-04  4:31 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-21  2:19 [PATCH v2] " Ryosuke Yasuoka
2026-05-25 11:05 ` Claude review: " Claude Code Review Bot
2026-05-25 11:05 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260601-virtio-gpu_wait_event-v3-1-89530517a98a@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox