From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: YUV support for VOP2 background color Date: Thu, 04 Jun 2026 13:48:14 +1000 Message-ID: In-Reply-To: <20260601-vop2-bg-yuv-v2-0-e5aef1d16fec@collabora.com> References: <20260601-vop2-bg-yuv-v2-0-e5aef1d16fec@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: YUV support for VOP2 background color Author: Cristian Ciocaltea Patches: 7 Reviewed: 2026-06-04T13:48:14.989595 --- This is a clean, well-structured 2-patch series that adds YUV format support for the VOP2 background color register. The motivation is clear: when the VOP2 overlay operates in YUV mode, the background color must also be programmed in YUV, but previously only RGB was supported. **Patch 1** is a trivial naming consistency fix. **Patch 2** is the substantive change, adding RGB-to-YCbCr conversion matrices derived from the well-established `v4l2-tpg-core.c` reference implementation. The conversion math is correct (verified against the BT.601/709/2020 standards), and the 16-bit precision arithmetic properly accounts for both limited and full range encoding. The refactoring of `vop2_post_config` to thread explicit old/new state pointers (rather than relying on `crtc->state`) is a good cleanup. The optimization to skip background color reprogramming when neither the color nor the colorspace changed is sensible. **No blocking issues found.** A couple of minor observations below. --- --- Generated by Claude Code Patch Reviewer