From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/qxl: fix local_gobj leak in qxl_gem_object_create_with_handle Date: Thu, 04 Jun 2026 14:38:32 +1000 Message-ID: In-Reply-To: <20260601064932.227375-1-lihongtao@kylinos.cn> References: <20260601064932.227375-1-lihongtao@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/qxl: fix local_gobj leak in qxl_gem_object_create_with_handle Author: Hongtao Lee Patches: 1 Reviewed: 2026-06-04T14:38:32.055574 --- This is a single-patch series that fixes a real GEM object reference leak in the QXL driver. The analysis is correct: when `qxl_gem_object_create()` succeeds, it returns a GEM object with a reference count. If the subsequent `drm_gem_handle_create()` call fails, the original code returned the error without dropping that reference, leaking the object. The fix is straightforward, correct, and follows established kernel patterns for GEM object cleanup. It's a clear bug that has existed since the QXL driver was first introduced. **Verdict: Good patch. Recommend applying.** --- Generated by Claude Code Patch Reviewer