From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver Date: Thu, 04 Jun 2026 14:19:35 +1000 Message-ID: In-Reply-To: <20260601095041.3042950-1-a-kumar2@ti.com> References: <20260601095041.3042950-1-a-kumar2@ti.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver Author: Abhash Kumar Jha Patches: 1 Reviewed: 2026-06-04T14:19:35.342050 --- This is a v3 single patch adding system suspend/resume support to the Cadence MHDP8546 DisplayPort bridge driver. The approach uses a genpd notifier to track whether the power domain was actually powered off during suspend, which determines whether firmware needs to be fully reloaded (after power loss) or just reactivated (after an aborted suspend). The patch also adds `phy_power_on`/`phy_power_off` calls that were previously missing from probe/remove. The general design is reasonable, but there are several issues ranging from a missing cleanup path (notifier removal) to clock management conflicts with `devm_clk_get_enabled`, a missing `hw_state` update on the resume error path, and inconsistent error handling compared to the existing remove code. --- Generated by Claude Code Patch Reviewer