From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: replace sprintf with snprintf Date: Thu, 04 Jun 2026 14:40:17 +1000 Message-ID: In-Reply-To: <2026060110-unlisted-headache-aec7@gregkh> References: <2026060110-unlisted-headache-aec7@gregkh> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] staging: fbtft: replace sprintf with snprintf Author: Greg KH Patches: 8 Reviewed: 2026-06-04T14:40:17.699184 --- This is a single-patch submission that replaces `sprintf` with `snprintf` i= n `fbtft_register_framebuffer()` in the staging fbtft driver. The change is= functionally correct but has several submission quality issues that would = likely result in the patch being rejected in its current form. **Submission issues:** 1. The patch was sent as a **base64-encoded MIME attachment** rather than i= nline in the email body. Kernel patches must be sent inline per `Documentat= ion/process/submitting-patches.rst`. Tools like `git send-email` should be = used. 2. The **commit message has no body** =E2=80=94 the Signed-off-by immediate= ly follows the subject. The cover letter text ("This patch replaces unsafe = sprintf calls...") should be the commit message body, not just in the email. 3. The **From name** in the email ("Enchanted Hunter") doesn't match the **= Signed-off-by name** ("rat1bor"). The kernel requires a real name for contr= ibutions; pseudonyms are generally not accepted. 4. The commit message in the cover letter body has formatting errors: "infb= tft_register_framebuffer()" (missing space after "in") and "overflow.Signed= -off-by" (missing newline before the tag). --- Generated by Claude Code Patch Reviewer