From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: lm3533: convert to OF bindings, improve support Date: Thu, 04 Jun 2026 13:59:53 +1000 Message-ID: In-Reply-To: <20260601151831.76350-1-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: mfd: lm3533: convert to OF bindings, improve support Author: Svyatoslav Ryhel Patches: 34 Reviewed: 2026-06-04T13:59:53.443885 --- This is a v3 series converting the LM3533 MFD driver from platform data to Device Tree bindings, adding VIN supply, DMA mask, mapping mode, and LED source configuration. The overall direction is good and the DT binding schemas are well-structured. However, there are several bugs that need to be fixed: 1. **Patch 2 has a regmap_update_bits argument swap bug** in one call site that would break ALS interrupt disable. 2. **Patch 5 has a DT property name mismatch** between the binding schema and driver code for the ALS resistor property. 3. **Patch 11 has a wide-mask bug** in the output config register writes that will clobber other banks' LED source assignments. The series needs another spin to fix these issues before it can be merged. --- --- Generated by Claude Code Patch Reviewer