From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Fix signed integer truncation in IPC receive Date: Thu, 04 Jun 2026 13:53:03 +1000 Message-ID: In-Reply-To: <20260601161643.229342-1-andrzej.kacprowski@linux.intel.com> References: <20260601161643.229342-1-andrzej.kacprowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Fix signed integer truncation in IPC receive Author: Andrzej Kacprowski Patches: 1 Reviewed: 2026-06-04T13:53:03.415757 --- This is a single-patch fix for a real integer truncation bug in the Intel V= PU (IVPU) IPC receive path. The issue is well-identified: `min_t(int, ...)`= casts a `u32` value (`data_size`) to `signed int`, which means values >=3D= 0x80000000 become negative. When that negative value is then used as a `u3= 2` (the type of `size`), it wraps to a very large unsigned value, leading t= o an oversized `memcpy` at line 291 that could overflow a stack buffer. The fix is correct and minimal =E2=80=94 replacing `min_t(int, ...)` with `= min()` =E2=80=94 since both operands (`data_size` is `u32`, `sizeof(...)` i= s `size_t`) are unsigned, making `min()` safe and appropriate here. The Fix= es tag, stable backport annotation, and commit message are all well-formed. **Verdict: This patch looks correct and ready to merge.** --- Generated by Claude Code Patch Reviewer