public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: convert CRIU event-private allocation to kvcalloc()
Date: Thu, 04 Jun 2026 13:42:10 +1000	[thread overview]
Message-ID: <review-overall-20260601195510.639318-1-william@theesfeld.net> (raw)
In-Reply-To: <20260601195510.639318-1-william@theesfeld.net>

Overall Series Review

Subject: drm/amdkfd: convert CRIU event-private allocation to kvcalloc()
Author: William Theesfeld <william@theesfeld.net>
Patches: 2
Reviewed: 2026-06-04T13:42:10.529206

---

This is a straightforward single-patch cleanup that converts an open-coded `kvzalloc(n * sizeof(*p), ...)` to `kvcalloc(n, sizeof(*p), ...)`. The change is correct and follows a well-established kernel hardening pattern — `kvcalloc()` uses `size_mul()` internally to detect multiplication overflow, whereas the open-coded form is vulnerable to silent integer overflow of `num_events * sizeof(*ev_privs)`.

The patch is small, well-scoped, and the commit message accurately describes both the change and its motivation. No functional change.

**Verdict: Looks good.** This is a standard mechanical hardening cleanup.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-06-04  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 19:55 [PATCH] drm/amdkfd: convert CRIU event-private allocation to kvcalloc() William Theesfeld
2026-06-03 16:16 ` Kuehling, Felix
2026-06-04  3:42 ` Claude review: " Claude Code Review Bot
2026-06-04  3:42 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260601195510.639318-1-william@theesfeld.net \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox