From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Document behaviour for framebuffer size mismatch Date: Thu, 04 Jun 2026 13:41:03 +1000 Message-ID: In-Reply-To: <20260601195732.72538-1-derek.foreman@collabora.com> References: <20260601195732.72538-1-derek.foreman@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: writeback: Document behaviour for framebuffer size mismatch Author: Derek Foreman Patches: 1 Reviewed: 2026-06-04T13:41:03.189082 --- This is a single documentation-only patch that adds three lines to the KDoc= comment for the `WRITEBACK_FB_ID` property in `drm_writeback.c`. It specif= ies the expected behavior when the writeback framebuffer dimensions don't m= atch the CRTC dimensions: the driver may either fail the commit or scale th= e content (but not crop). The patch is reasonable and addresses a genuine gap in the writeback connec= tor specification. The rationale in the commit message is sound =E2=80=94 c= ropping is underspecified without an origin/viewport property, while scalin= g is well-defined. **Minor concerns:** 1. The wording "the driver may either fail or scale (not crop)" is clear bu= t could be slightly more precise about *when* the failure occurs =E2=80=94 = it should be at atomic check time, not silently at commit time. A `TEST_ONL= Y` commit should be able to discover this. 2. There's no mention of whether the scaling should preserve aspect ratio o= r stretch. For a UAPI doc, it might be worth stating this is implementation= -defined, or that the framebuffer dimensions define the output size (i.e., = stretch to fit). 3. The patch does not add any helper validation or enforcement in the core = =E2=80=94 it's purely documenting what drivers are allowed to do. That's fi= ne for now, but a follow-up adding a core helper (e.g., a flag on `drm_writ= eback_connector` indicating scaling support) would make this more useful an= d consistent across drivers. --- --- Generated by Claude Code Patch Reviewer