From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: Fix silent overflow for phys vec to sgt
Date: Thu, 04 Jun 2026 13:39:51 +1000 [thread overview]
Message-ID: <review-overall-20260601200012.3872274-1-xuehaohu@google.com> (raw)
In-Reply-To: <20260601200012.3872274-1-xuehaohu@google.com>
Overall Series Review
Subject: dma-buf: Fix silent overflow for phys vec to sgt
Author: David Hu <xuehaohu@google.com>
Patches: 2
Reviewed: 2026-06-04T13:39:51.634825
---
This is a single-patch fix for a real silent integer overflow bug in the dma-buf MMIO-to-scatterlist mapping path. When MMIO regions exceed 4GB and P2P DMA goes through the host bridge, `mapped_len` (previously `unsigned int`) wraps around when accumulating `size_t` lengths, causing truncated values to be passed to `dma_iova_sync()` and `fill_sg_entry()`. The fix is minimal, well-targeted, and at v5 has addressed all prior reviewer feedback. The patch looks correct and ready to merge.
**Verdict: Looks good. No blocking issues.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 3:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 20:00 [PATCH v5] dma-buf: Fix silent overflow for phys vec to sgt David Hu
2026-06-03 7:04 ` Tian, Kevin
2026-06-04 3:39 ` Claude Code Review Bot [this message]
2026-06-04 3:39 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 20:50 [PATCH v2] " David Hu
2026-05-28 2:05 ` Claude review: " Claude Code Review Bot
2026-05-28 2:05 ` Claude Code Review Bot
2026-05-11 21:42 [PATCH] " David Hu
2026-05-16 4:37 ` Claude review: " Claude Code Review Bot
2026-05-16 4:37 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260601200012.3872274-1-xuehaohu@google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox