From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dynamic-debug cleanups refactors maintenance + alignment fix Date: Thu, 04 Jun 2026 12:12:45 +1000 Message-ID: In-Reply-To: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dynamic-debug cleanups refactors maintenance + alignment fix Author: Jim Cromie Patches: 26 Reviewed: 2026-06-04T12:12:45.976321 --- This is a 25-patch series from Jim Cromie performing dynamic-debug cleanups, refactors, and a bug fix for linker-script alignment on i386. The series is well-structured, progressing from doc updates and linker fixes, through progressive dyndbg refactoring (extract functions, simplify data structures, normalize naming), to the final payoff patches: u64 class param storage (fixing 32-bit arch truncation), statement-expression macros (fixing Xe driver usage), and KBUILD_MODFILE for unique builtin module names (fixing classmap ambiguity). **DRM relevance:** Patches 18, 19, and 23 directly touch `drm_print.c`/`drm_print.h`. Patch 18 changes `__drm_debug` from `unsigned long` to `u64` and the module_param type from `ulong` to `ullong`. Patch 19 renames `struct ddebug_class_param` to `struct _ddebug_class_param` in drm_print.c. Patch 23 fixes a real build issue where `CONFIG_DRM_USE_DYNAMIC_DEBUG=y` breaks the Xe driver's `XE_IOCTL_DBG` macro by converting do-while-0 macros to statement-expressions. The series is generally sound, with the core refactoring well-ordered. There are a few issues, mostly cosmetic, and one potential concern around operator precedence in the CLASSMAP_BITMASK macro. --- Generated by Claude Code Patch Reviewer