From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: add missing drm_edid_connector_update() before add_modes on cached EDID Date: Thu, 04 Jun 2026 12:21:12 +1000 Message-ID: In-Reply-To: <20260602-drm_plug_flaky_edid-v2-1-1269fb942299@oldschoolsolutions.biz> References: <20260602-drm_plug_flaky_edid-v2-1-1269fb942299@oldschoolsolutions.biz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dp: add missing drm_edid_connector_update() before add_mod= es on cached EDID Author: Jens Glathe via B4 Relay Patches: 1 Reviewed: 2026-06-04T12:21:12.498053 --- This is a single-patch fix for a real regression introduced by commit 5bea9= 0ad9743 ("drm/msm/dp: switch to struct drm_edid"). The analysis is correct:= the `struct drm_edid` API requires `drm_edid_connector_update()` to be cal= led before `drm_edid_connector_add_modes()`, as explicitly documented in th= e kernel (`drm_edid.c:7152`: "Must be called before calling drm_edid_connec= tor_add_modes()"). The initial EDID read path (`msm_dp_panel_read_sink_caps= ` at line 281) already calls `drm_edid_connector_update()`, but when `msm_d= p_panel_get_modes()` is called with a cached EDID (i.e., the EDID was read = on an earlier call), the connector's internal state may not have the EDID a= ssociated =E2=80=94 for instance, after a connector reset or if `get_modes`= is called on a different connector lifecycle. The fix is minimal, correct,= and well-motivated by the v2 cover letter analysis. **Verdict: Looks good. Recommend merge.** --- Generated by Claude Code Patch Reviewer